[Fixed] Module State Changes on Editing

RicoFlan · 04-03-2007, 11:01 AM

Go to the Module Manager in the Admin system...

When a Module that is not assigned to any pages (Pages = "None") is selected, when the Module is opened for editing, the "Pages/Items" dialogue defaults to "All". It sd say "None".

Tengu · 04-03-2007, 11:19 AM

Confirmed!

Elpie · 22-03-2007, 01:49 PM

Referenced in Tracker: http://tracker.mambo-foundation.org/...ls&task_id=215

This appears to have been the default behaviour for some time. It will be investigated further and changes made in a later version.

**konlong** · 23-04-2007, 02:47 PM

An answer to this problem requires the following mods:
line 264 of admin.modules.php to

PHP Code:


			
if ( $menuid <> "-999" && $menuid <> "-998") {

and in file mosAdminMenus.php
change line 274 to

PHP Code:


			
$mitems[] = mosHTML::makeOption( -998, T_('None') );

then insert the following after line 281

PHP Code:


			
if ($lookup == NULL) {

   $lookup = '-998';

  }

cauld · 23-04-2007, 04:50 PM

Good catch konlong. I gave this one a play last week and hadn't quite figured out the issue. Looks like you've got it. I'll give you solution a try and report back.

cauld · 24-04-2007, 01:49 AM

Cheers konlong

. Worked like a charm. I have committed for the final 4.6.2 build.

**konlong** · 24-04-2007, 08:40 AM

It was my pleasure,

John

neilt · 25-04-2007, 01:29 PM

Hi Chad

Was this ever committed as I've just spent 3 hours looking at this as it didn;t work on my pc with the latest 4.6 svn only to find it's been sorted?

cauld · 25-04-2007, 03:22 PM

Originally Posted by neilt

Hi Chad

Was this ever committed as I've just spent 3 hours looking at this as it didn;t work on my pc with the latest 4.6 svn only to find it's been sorted?

I got it in the patch, but missed it in the full build/svn. I got it in their this morning. SVN and SF downloads now have it.

neilt · 25-04-2007, 03:52 PM

superb, cheers.

04-03-2007, 11:01 AM	#1
RicoFlan Mambo Master Join Date: May 2006 Location: Bali, Indonesia Posts: 1,314	[Fixed] Module State Changes on Editing Go to the Module Manager in the Admin system... When a Module that is not assigned to any pages (Pages = "None") is selected, when the Module is opened for editing, the "Pages/Items" dialogue defaults to "All". It sd say "None". __________________ http://www.mambo-extensions.com Would you like to upport Mambo by making a donation through PayPal?

04-03-2007, 11:19 AM	#2
Tengu Mambo Guru Join Date: Dec 2006 Location: The Netherlands Posts: 4,800	Confirmed! __________________ Mambo-ing since december 2006 and loving it! - Tengu webDesign: Custom made templates, Mambo upgrades and webBuilding (http://www.tengu.nl) - Pleased with Mambo and the support? Consider making a donation to the Mambo Foundation

22-03-2007, 01:49 PM	#3
Elpie Mambo Guru Forum Admin Join Date: Jul 2006 Location: New Zealand Posts: 10,001	Referenced in Tracker: http://tracker.mambo-foundation.org/...ls&task_id=215 This appears to have been the default behaviour for some time. It will be investigated further and changes made in a later version. __________________ Mambo Tutorials on:http://lynnepope.net/topics/mambo-tutorials Mambo wiki: http://mambo-manual.org/ Follow me: http://twitter.com/elpie Last edited by Elpie; 23-04-2007 at 02:07 PM.

23-04-2007, 02:47 PM	#4
konlong Mambo Fan Programming Join Date: Oct 2006 Location: Delaware Posts: 37	Re: [bug] Module State Changes on Editing An answer to this problem requires the following mods: line 264 of admin.modules.php to PHP Code: `if ( $menuid <> "-999" && $menuid <> "-998") {` and in file mosAdminMenus.php change line 274 to PHP Code: `$mitems[] = mosHTML::makeOption( -998, T_('None') );` then insert the following after line 281 PHP Code: `if ($lookup == NULL) { $lookup = '-998'; }`

23-04-2007, 04:50 PM	#5
cauld Mambo Guru Join Date: May 2006 Location: California, USA Posts: 2,976	Re: [bug] Module State Changes on Editing Good catch konlong. I gave this one a play last week and hadn't quite figured out the issue. Looks like you've got it. I'll give you solution a try and report back. __________________ http://brilaps.com http://opensourcepenguin.net

24-04-2007, 01:49 AM	#6
cauld Mambo Guru Join Date: May 2006 Location: California, USA Posts: 2,976	Re: [bug] Module State Changes on Editing Cheers konlong . Worked like a charm. I have committed for the final 4.6.2 build. __________________ http://brilaps.com http://opensourcepenguin.net

24-04-2007, 08:40 AM	#7
konlong Mambo Fan Programming Join Date: Oct 2006 Location: Delaware Posts: 37	Re: [Fixed] Module State Changes on Editing It was my pleasure, John

25-04-2007, 01:29 PM	#8
neilt Mambo Supporter Join Date: May 2006 Location: Kent, UK Posts: 272	Re: [Fixed] Module State Changes on Editing Hi Chad Was this ever committed as I've just spent 3 hours looking at this as it didn;t work on my pc with the latest 4.6 svn only to find it's been sorted? __________________ Neil Thompson ----------------------------------------------------------------- I ignore your reality and substitute my own

25-04-2007, 03:22 PM	#9
cauld Mambo Guru Join Date: May 2006 Location: California, USA Posts: 2,976	Re: [Fixed] Module State Changes on Editing Originally Posted by neilt Hi Chad Was this ever committed as I've just spent 3 hours looking at this as it didn;t work on my pc with the latest 4.6 svn only to find it's been sorted? I got it in the patch, but missed it in the full build/svn. I got it in their this morning. SVN and SF downloads now have it. __________________ http://brilaps.com http://opensourcepenguin.net

25-04-2007, 03:52 PM	#10
neilt Mambo Supporter Join Date: May 2006 Location: Kent, UK Posts: 272	Re: [Fixed] Module State Changes on Editing superb, cheers. __________________ Neil Thompson ----------------------------------------------------------------- I ignore your reality and substitute my own

New To Site?	Need Help?
What is Mambo? Forum Rules Register to Participate View Forum Leaders Frequently Asked Questions	Help Us to Help You - Donate Did you forget your password? Mark Forums Read Privacy Statement Contact Us